Explorar o código

[공통][Common] PMD Analyze CompareObjectsWithEquals 해결

Hasemi %!s(int64=6) %!d(string=hai) anos
pai
achega
711807345f

+ 3 - 0
app/src/main/java/kr/co/zumo/app/lifeplus/view/SingleSelector.java

@@ -58,6 +58,7 @@ public class SingleSelector<T> {
    *
    * @param trigger
    */
+  @SuppressWarnings("PMD.CompareObjectsWithEquals")
   public void check(T trigger, boolean isTriggerChecked) {
     // 리스트에 속한 박스라면 다른 박스를 해제 시킨다.
     if (boxes.indexOf(trigger) > -1) {
@@ -78,6 +79,7 @@ public class SingleSelector<T> {
    *
    * @param box
    */
+  @SuppressWarnings("PMD.CompareObjectsWithEquals")
   public void uncheck(T box) {
     if (boxes.indexOf(box) > -1) {
       List<T> list = new ArrayList<>();
@@ -109,6 +111,7 @@ public class SingleSelector<T> {
 
   public interface Listener<T> {
     void onChecked(T trigger, boolean isTriggerChecked, List<T> unchecked);
+
     void onUnchecked(List<T> unchecked);
   }
 }

+ 1 - 0
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/contents/CustomPagerSnapHelper.java

@@ -256,6 +256,7 @@ public class CustomPagerSnapHelper extends RecyclerView.OnFlingListener {
    * @throws IllegalArgumentException if there is already a {@link RecyclerView.OnFlingListener}
    *                                  attached to the provided {@link RecyclerView}.
    */
+  @SuppressWarnings("PMD.CompareObjectsWithEquals")
   public void attachToRecyclerView(@Nullable RecyclerView recyclerView)
     throws IllegalStateException {
     if (mRecyclerView == recyclerView) {

+ 1 - 0
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/main/MainCategorySnapper.java

@@ -111,6 +111,7 @@ public class MainCategorySnapper extends RecyclerView.OnFlingListener {
    * @throws IllegalArgumentException if there is already a {@link RecyclerView.OnFlingListener}
    *                                  attached to the provided {@link RecyclerView}.
    */
+  @SuppressWarnings("PMD.CompareObjectsWithEquals")
   public void attachToRecyclerView(@Nullable RecyclerView recyclerView) throws IllegalStateException {
     if (mRecyclerView == recyclerView) {
       return; // nothing to do

+ 2 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/main/MainContentsSnapper.java

@@ -101,6 +101,7 @@ public class MainContentsSnapper extends RecyclerView.OnFlingListener {
    * @throws IllegalArgumentException if there is already a {@link RecyclerView.OnFlingListener}
    *                                  attached to the provided {@link RecyclerView}.
    */
+  @SuppressWarnings("PMD.CompareObjectsWithEquals")
   public void attachToRecyclerView(@Nullable RecyclerView recyclerView) throws IllegalStateException {
     if (mRecyclerView == recyclerView) {
       return; // nothing to do
@@ -306,7 +307,7 @@ public class MainContentsSnapper extends RecyclerView.OnFlingListener {
           OrientationHelper helper = getOrientationHelper(layoutManager);
           if (null != helper) {
             {}
-           // offset = (helper.getEnd() - helper.getDecoratedMeasurement(targetView));
+            // offset = (helper.getEnd() - helper.getDecoratedMeasurement(targetView));
           }
 //          Log.e("APP#  MainCategorySnapper | onTargetFound", "|" + "layoutManager.getWidth(): " + layoutManager.getWidth());
 //          Log.e("APP#  MainCategorySnapper | onTargetFound", "|" + "helper.getDecoratedMeasurement(targetView): " + helper.getDecoratedMeasurement(targetView));

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/my/bucketlist/BestBucketListPagerAdapter.java

@@ -50,7 +50,7 @@ public class BestBucketListPagerAdapter extends PagerAdapter {
 
   @Override
   public boolean isViewFromObject(@NonNull View view, @NonNull Object object) {
-    return view == object;
+    return view.equals(object);
   }
 
   @NonNull

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/my/bucketlist/MyBucketListBannerPagerAdapter.java

@@ -50,7 +50,7 @@ public class MyBucketListBannerPagerAdapter extends PagerAdapter {
 
   @Override
   public boolean isViewFromObject(@NonNull View view, @NonNull Object object) {
-    return view == object;
+    return view.equals(object);
   }
 
   @NonNull

+ 2 - 2
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/onboarding/OnBoardingPagerAdapter.java

@@ -30,7 +30,7 @@ public class OnBoardingPagerAdapter extends PagerAdapter {
   protected View tabLayout;
   protected LayoutInflater layoutInflater;
   private Presenter presenter;
- // private static final int VIEW_COUNT = 5;
+  // private static final int VIEW_COUNT = 5;
   private static final int VIEW_COUNT = 1;
 
   /**
@@ -71,7 +71,7 @@ public class OnBoardingPagerAdapter extends PagerAdapter {
    */
   @Override
   public boolean isViewFromObject(@NonNull View view, @NonNull Object object) {
-    return view == object;
+    return view.equals(object);
 
   }