Przeglądaj źródła

[공통][Common] PMD Analyze 적용

Hasemi 6 lat temu
rodzic
commit
7801eb71ee

+ 4 - 2
app/src/main/java/kr/co/zumo/app/lifeplus/bean/api/BookmarkBean.java

@@ -65,7 +65,7 @@ public class BookmarkBean extends LifeplusContentsBean {
     return listItemNo;
   }
 
-  public void setListItemNo(String listItemNo) {
+  public final void setListItemNo(String listItemNo) {
     this.listItemNo = listItemNo;
   }
 
@@ -105,7 +105,9 @@ public class BookmarkBean extends LifeplusContentsBean {
    *
    * @return
    */
-  public BookmarkBean clone() {
+
+  public BookmarkBean getClone() {
+
     BookmarkBean bean = new BookmarkBean(this);
     bean.setCategoryNumber(getCategoryNumber());
     bean.setBookmarkNumber(getBookmarkNumber());

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/bean/api/LifeplusContentsBean.java

@@ -207,7 +207,7 @@ public class LifeplusContentsBean extends JsonBeanBase implements IImageTitleBea
    *
    * @return
    */
-  public LifeplusContentsBean clone() {
+  public LifeplusContentsBean getClone() {
     LifeplusContentsBean bean = new LifeplusContentsBean();
     bean.setItemNo(getItemNo());
     bean.setTitle(getTitle());

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/Event.java

@@ -338,7 +338,7 @@ public class Event {
    *
    * @return new Builder;
    */
-  public Builder clone() {
+  public Builder getClone() {
     return new Builder(getEventId()).string(getString()).integer(getInteger()).index(getIndex()).json(getJson()).bool(getBool());
   }
 

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/contents/ContentsPresenter.java

@@ -250,7 +250,7 @@ public class ContentsPresenter extends ContentsBasePresenter<ContentsModel, ICon
           // Series 는 itemNo 가 Series 를 가리키고 seriesItemNo 가 contents 의 itemNo 이므로
           // 그대로 contentsView 에 전달하면 공유 등 문제가 있다.
           // 이를 clone()하여 새로운 bean 으로 전달한다.
-          LifeplusContentsBean bean = model.getSelectedSeriesItemBean().clone();
+          LifeplusContentsBean bean = model.getSelectedSeriesItemBean().getClone();
           model.setDeliveryPackaging(new ContentsDeliveryBean.Builder(bean).build());
           go(ScreenID.CONTENTS);
         });

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/contents/series/ContentsSeriesPresenter.java

@@ -81,7 +81,7 @@ public class ContentsSeriesPresenter extends Presenter<ContentsSeriesModel, ICon
         // Series 는 itemNo 가 Series 를 가리키고 seriesItemNo 가 contents 의 itemNo 이므로
         // 그대로 contentsView 에 전달하면 공유 등 문제가 있다.
         // 이를 clone()하여 새로운 bean 으로 전달한다.
-        LifeplusContentsBean bean = model.getContentsBean().clone();
+        LifeplusContentsBean bean = model.getContentsBean().getClone();
         ContentsDeliveryBean contentsDeliveryBean = new ContentsDeliveryBean.Builder(bean).build();
 
         model.setDeliveryPackaging(contentsDeliveryBean);

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/event/select/EventSelectPageCombinedHolder.java

@@ -108,7 +108,7 @@ public class EventSelectPageCombinedHolder extends EventDetailView {
       List<EventAnswerItemBean> list = eventQuestionBean.getEventAnswerItemBeanList();
       eventSelectCombinedListAdapter = new EventSelectCombinedListAdapter(itemView.getContext(), list, event -> {
         // 페이지 인덱스를 추가해준다.
-        listener.onEvent(event.clone().index(getAdapterPosition()).build());
+        listener.onEvent(event.getClone().index(getAdapterPosition()).build());
       });
 
       recyclerView.setAdapter(eventSelectCombinedListAdapter);

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/main/MainContentsCategoryHolder.java

@@ -169,7 +169,7 @@ public class MainContentsCategoryHolder extends MainContentsHolder {
       switch (event.getEventId()) {
         case Event.CONTENTS:
           // event.getInteger() = contents index
-          listener.onEvent(event.clone().index(index).build());
+          listener.onEvent(event.getClone().index(index).build());
           break;
 //        case Event.MORE:
 //          listener.onEvent(event);

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/my/bookmark/BookMarkListAdapter.java

@@ -61,7 +61,7 @@ public class BookMarkListAdapter extends RecyclerView.Adapter<BookMarkListView>
         // view 의 index 와 model 의 그것이 달라서 itemNumber 로 확인
         BookmarkBean bookmarkBean = bookmarkBeans.get(idx);
         ListItemNumberBean listItemNumberBean = new ListItemNumberBean(bookmarkBean.getItemNo(), bookmarkBean.getListItemNo());
-        event = event.clone().index(-1).json(listItemNumberBean.toJson()).build();
+        event = event.getClone().index(-1).json(listItemNumberBean.toJson()).build();
         listener.onEvent(event);
       }
     });

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/my/bookmark/BookMarkListModel.java

@@ -152,7 +152,7 @@ public class BookMarkListModel extends Model {
 //          bookmarks.set(index, beans);
 //        }
         // 복사해서 넣어준다.
-        beans.add(bean.clone());
+        beans.add(bean.getClone());
       }
     }
 

+ 3 - 3
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/search/SearchFragment.java

@@ -170,7 +170,7 @@ public class SearchFragment extends FragmentBase<SearchPresenter> implements ISe
     Log.i("APP# SearchFragment | drawLatestTag", "| contentsBeans.size(): " + tagBeans.size());
     if (null == latestTagListAdapter) {
       latestTagListAdapter = new TagListAdapter(tagBeans, event -> {
-        presenter.onEvent(event.clone().integer(Event.TAG_LATEST).build());
+        presenter.onEvent(event.getClone().integer(Event.TAG_LATEST).build());
       });
       recyclerViewLatestTag.setAdapter(latestTagListAdapter);
     }
@@ -183,7 +183,7 @@ public class SearchFragment extends FragmentBase<SearchPresenter> implements ISe
   public void drawPopularTag(List<TagBean> tagBeans) {
     if (null == popularTagListAdapter) {
       popularTagListAdapter = new TagPopularAdapter(tagBeans, event -> {
-        presenter.onEvent(event.clone().integer(Event.TAG_POPULAR).build());
+        presenter.onEvent(event.getClone().integer(Event.TAG_POPULAR).build());
       });
       recyclerViewPopularTag.setAdapter(popularTagListAdapter);
     }
@@ -196,7 +196,7 @@ public class SearchFragment extends FragmentBase<SearchPresenter> implements ISe
   public void drawAutoCompletionTag(List<TagKeywordBean> tagBeans) {
     if (null == autoCompletionTagListAdapter) {
       autoCompletionTagListAdapter = new TagAutoCompletionAdapter(tagBeans, event -> {
-        presenter.onEvent(event.clone().integer(Event.TAG_AUTO_COMPLETION).build());
+        presenter.onEvent(event.getClone().integer(Event.TAG_AUTO_COMPLETION).build());
       });
       recyclerViewAutoCompletion.setAdapter(autoCompletionTagListAdapter);
     }