浏览代码

[공통][Bug] Presenter.dispose(int) -> .onDispose() 이름/파라메터 변경

hyodong.min 7 年之前
父节点
当前提交
7ec595ba8c

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/MainPresenter.java

@@ -31,7 +31,7 @@ public class MainPresenter extends Presenter<MainModel, IMainView> {
   }
 
   @Override
-  protected void dispose(int nothing) {
+  protected void onDispose() {
   }
 
   @Override

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/NetworkErrorPresenter.java

@@ -39,7 +39,7 @@ public class NetworkErrorPresenter extends Presenter<NetworkErrorModel, INetwork
   }
 
   @Override
-  public void dispose(int nothing) {
+  protected void onDispose() {
     if (null != disposable) {
       disposable.dispose();
       disposable = null;

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/PinPresenter.java

@@ -41,7 +41,7 @@ public class PinPresenter extends Presenter<PinModel, IPinView> {
   }
 
   @Override
-  public void dispose(int nothing) {
+  protected void onDispose() {
     if (null != disposable) {
       disposable.dispose();
       disposable = null;

+ 15 - 12
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/Presenter.java

@@ -36,20 +36,24 @@ public abstract class Presenter<M extends Model, V extends IView> implements INe
     this.view = view;
   }
 
-  /**
-   * start
-   */
-  public abstract void start();
-
   /**
    * dispose
    */
   public final void dispose() {
     model.dispose();
 
-    dispose(0);
+    onDispose();
   }
-  protected abstract void dispose(int nothing);
+
+  /***********************************
+   * abstract
+   ***********************************/
+  /**
+   * start
+   */
+  public abstract void start();
+
+  protected abstract void onDispose();
 
   /**
    * 장치 back key 눌렸을 경우 처리한다.
@@ -64,6 +68,7 @@ public abstract class Presenter<M extends Model, V extends IView> implements INe
    * View 로 부터 전달된 이벤트를 처리한다.
    * - 공통 처리가 필요한 이벤트를 처리한 뒤
    * - 각 Presenter.performOnEvent(Event) 에서 세부 처리한다.
+   *
    * @param event
    */
   public void onEvent(Event event) {
@@ -72,11 +77,9 @@ public abstract class Presenter<M extends Model, V extends IView> implements INe
 
   protected abstract void performOnEvent(Event event);
 
-  /**
-   * 뷰로 부터 전달된 커멘드를 실행한다.
-   *
-   * @param command Command
-   */
+  /***********************************
+   * method
+   ***********************************/
   void onCommand(Command command) {
     this.command = command;
     Log.w("APP# Presenter | onCommand", "| command: " + command.getClass().getSimpleName() + ", " + new Gson().toJson(command));

+ 2 - 2
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/SignUpPresenter.java

@@ -66,8 +66,8 @@ public class SignUpPresenter extends Presenter<SignUpModel, ISignUpView> {
   }
 
   @Override
-  public void dispose(int nothing) {
-    Log.i("APP# SignUpPresenter | dispose", "|" + "-------------------------> ");
+  protected void onDispose() {
+    Log.i("APP# SignUpPresenter | onDispose", "|" + "-------------------------> ");
     if (null != step) {
       step.dispose();
       step = null;

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/TutorialPresenter.java

@@ -32,7 +32,7 @@ public class TutorialPresenter extends Presenter<TutorialModel, ITutorialView> {
   }
 
   @Override
-  public void dispose(int nothing) {
+  protected void onDispose() {
   }
 
   @Override