Explorar el Código

[공통][Bug] Todo 정리

hyodong.min hace 7 años
padre
commit
e108d7433d

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/model/SignUpModel.java

@@ -258,7 +258,7 @@ public class SignUpModel extends Model {
             onResult(new Event.Builder(Event.RESULT).integer(EVENT_JOINED).build());
           }, e -> {
 
-            // fixme 파싱 에러 발생!!! 임로 성공 시킴;
+            // fixme 파싱 에러 발생!!! 임로 성공 시킴;
             if (AppUtil.isDebug()) {
               saveUserId("_____________dummy_user_id______________");
               onResult(new Event.Builder(Event.RESULT).integer(EVENT_JOINED).build());

+ 6 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/fragment/signup/SignUpMobileAuthFragment.java

@@ -9,6 +9,7 @@ import android.view.ViewGroup;
 
 import kr.co.zumo.app.R;
 import kr.co.zumo.app.lifeplus.model.SignUpModel;
+import kr.co.zumo.app.lifeplus.view.Event;
 import kr.co.zumo.app.lifeplus.view.ISignUpView;
 import kr.co.zumo.app.lifeplus.view.custom.auth.IMobileAuthContract;
 import kr.co.zumo.app.lifeplus.view.custom.auth.MobileAuthorizationPresenter;
@@ -46,7 +47,11 @@ public class SignUpMobileAuthFragment extends FragmentBase<SignUpMobileAuthPrese
   protected void onAfterActivityCreated(Bundle savedInstanceState) {
 
     authView = new MobileAuthorizationView(getContext());
-    authPresenter = new MobileAuthorizationPresenter(authView, event -> presenter.onEvent(event));
+    authPresenter = new MobileAuthorizationPresenter(authView, event -> {
+      if (Event.SUCCESS == event.getEventId()) {
+        presenter.onEvent(event);
+      }
+    });
 
     ViewGroup layout = getView().findViewById(R.id.container);
     ViewGroup.LayoutParams params = new ViewGroup.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT);

+ 0 - 11
app/src/main/java/kr/co/zumo/app/lifeplus/view/presenter/signup/SignUpMobileAuthPresenter.java

@@ -25,7 +25,6 @@ import kr.co.zumo.app.lifeplus.bean.api.LifeplusAPIBean;
 import kr.co.zumo.app.lifeplus.manager.ActionBarManager;
 import kr.co.zumo.app.lifeplus.model.SignUpModel;
 import kr.co.zumo.app.lifeplus.supervisor.ScreenID;
-import kr.co.zumo.app.lifeplus.util.AppUtil;
 import kr.co.zumo.app.lifeplus.util.Formatter;
 import kr.co.zumo.app.lifeplus.util.ResourceUtil;
 import kr.co.zumo.app.lifeplus.util.StringUtil;
@@ -116,15 +115,6 @@ public class SignUpMobileAuthPresenter extends SignUpFragmentPresenter {
         Log.i("APP# SignUpMobileAuthPresenter | onEventInternal", "|" + "resultString: " + event.getJson());
         onAuthResult(event);
         break;
-      case Event.FAIL:
-        // todo 모바일 인증 실패
-        break;
-      case Event.CANCEL:
-        // fixme for test
-        if (AppUtil.isDebug()) {
-          onEvent(new Event.Builder(Event.CONFIRM).build());
-        }
-        break;
       default:
         break;
     }
@@ -138,7 +128,6 @@ public class SignUpMobileAuthPresenter extends SignUpFragmentPresenter {
     Log.w("APP# SignUpMobileAuthPresenter | onEventInternal", "| 유저 데이터: " + mobileAuthBean.toPrettyJson());
 
     /**
-     * // todo 아래 코드는 팝업 외에서 처리해야 한다.
      * 2. 성공 시 PROCESS 진입
      1) 만 14세 이상 : 약관동의(JO2001)화면 링크
      2) 14세 미만 : 14세 미만 가입불가 안내 (JO5002) 화면 링크