[컨텐츠][New] 앱리뷰 리팩토링

app/src/main/java/kr/co/zumo/app/lifeplus/model/LifeplusPreferences.java

@@ -18,9 +18,6 @@ package kr.co.zumo.app.lifeplus.model;
 public class LifeplusPreferences {
   private BaseSharedPreferences preferences;
 
-  // 리뷰 확인 했음
-  public static final String REVIEW_COMPLETED = "completed";
-
   public final static String ENCRYPTION_USER_NO = "encryption_user_no";
   public final static String ZUMO_USER_UPDATE_COMPLETED = "zumo_user_update_completed";
   public final static String USER_ID = "user_id";

app/src/main/java/kr/co/zumo/app/lifeplus/tool/ReviewCounter.java

@@ -26,8 +26,10 @@ import kr.co.zumo.app.lifeplus.util.StringUtil;
  */
 public class ReviewCounter {
 
-  private final String DATE_PATTERN = "yyMMdd";
-  private final String SEPARATOR = ":";
+  // 리뷰 확인 했음
+  public static final String REVIEW_COMPLETED = "completed";
+  private static final String DATE_PATTERN = "yyMMdd";
+  private static final String SEPARATOR = ":";
 
   private final String dateString;
   private final long todayMillis;
@@ -50,7 +52,7 @@ public class ReviewCounter {
    */
   public void countForReview() {
     String date = dateString;
-    if (LifeplusPreferences.REVIEW_COMPLETED.equals(date)) {
+    if (REVIEW_COMPLETED.equals(date)) {
       return;
     }
 
@@ -89,7 +91,7 @@ public class ReviewCounter {
    */
   public boolean canReview() {
     String date = dateString;
-    if (LifeplusPreferences.REVIEW_COMPLETED.equals(date)) {
+    if (REVIEW_COMPLETED.equals(date)) {
       return false;
     }
 
@@ -113,6 +115,6 @@ public class ReviewCounter {
    * 리뷰 했음 표시
    */
   public void setReviewCompleted() {
-    preferences.setCountForReview(LifeplusPreferences.REVIEW_COMPLETED);
+    preferences.setCountForReview(REVIEW_COMPLETED);
   }
 }

app/src/test/java/kr/co/zumo/app/lifeplus/tool/ReviewCounterTest.java

@@ -61,7 +61,7 @@ public class ReviewCounterTest {
   public void countForReviewCompleted() {
 
     // 완료 일 경우 카운트 되지 않음
-    dates = LifeplusPreferences.REVIEW_COMPLETED;
+    dates = ReviewCounter.REVIEW_COMPLETED;
     new ReviewCounter(preferences, dates, todayMillis).countForReview();
 
     verify(preferences, times(0)).setCountForReview(any());
@@ -84,7 +84,7 @@ public class ReviewCounterTest {
     dates = "181212:181212:181213:181214:181215:181221";
     assertTrue(new ReviewCounter(preferences, dates, todayMillis).canReview());
 
-    dates = LifeplusPreferences.REVIEW_COMPLETED;
+    dates = ReviewCounter.REVIEW_COMPLETED;
     assertFalse(new ReviewCounter(preferences, dates, todayMillis).canReview());
   }
 
@@ -92,7 +92,7 @@ public class ReviewCounterTest {
   public void setReviewCompleted() {
     dates = "";
     new ReviewCounter(preferences, dates, todayMillis).setReviewCompleted();
-    verify(preferences, times(1)).setCountForReview(eq(LifeplusPreferences.REVIEW_COMPLETED));
+    verify(preferences, times(1)).setCountForReview(eq(ReviewCounter.REVIEW_COMPLETED));
 
   }
 }