Browse Source

[공통][New] Google Analytics - refactoring

hyodong.min 6 years ago
parent
commit
f468e86c2c

+ 10 - 11
app/src/main/java/kr/co/zumo/app/lifeplus/helper/FirebaseAnalyticsHelper.java

@@ -26,11 +26,10 @@ public class FirebaseAnalyticsHelper extends Helper {
 
   public static class Param {
     static final String SCREEN = "screen";
-    static final String ITEM_NAME = "item_name";
     static final String CATEGORY_INDEX = "category_index";
     static final String CATEGORY_NAME = "category_name";
-    static final String CONTENTS_INDEX = "contents_index";
-    static final String CONTENTS_NAME = "contents_name";
+    static final String ITEM_INDEX = "item_index";
+    static final String ITEM_NAME = "item_name";
 
     public static final String TYPE = "type";
     public static final String TYPE_RECOMMEND = "추천";
@@ -186,9 +185,9 @@ public class FirebaseAnalyticsHelper extends Helper {
     Bundle params = new Bundle();
     params.putString(Param.SCREEN, screen);
     params.putString(Param.CATEGORY_INDEX, String.valueOf(categoryIndex));
-    params.putString(Param.CATEGORY_NAME, context.getString(R.string.fa_main_category_string, categoryIndex, categoryLabel));
-    params.putString(Param.CONTENTS_INDEX, String.valueOf(contentIndex));
-    params.putString(Param.CONTENTS_NAME, context.getString(R.string.fa_main_contents_string, contentIndex, contentLabel));
+    params.putString(Param.CATEGORY_NAME, context.getString(R.string.fa_category_string, categoryIndex, categoryLabel));
+    params.putString(Param.ITEM_INDEX, String.valueOf(contentIndex));
+    params.putString(Param.ITEM_NAME, context.getString(R.string.fa_contents_string, contentIndex, contentLabel));
 
     return params;
   }
@@ -219,9 +218,9 @@ public class FirebaseAnalyticsHelper extends Helper {
     Bundle params = new Bundle();
     params.putString(Param.SCREEN, screen);
     params.putString(Param.CATEGORY_INDEX, String.valueOf(categoryIndex));
-    params.putString(Param.CATEGORY_NAME, context.getString(R.string.fa_main_category_string, categoryIndex, categoryLabel));
-    params.putString(Param.CONTENTS_INDEX, String.valueOf(contentIndex));
-    params.putString(Param.CONTENTS_NAME, context.getString(R.string.fa_main_contents_string, contentIndex, contentLabel));
+    params.putString(Param.CATEGORY_NAME, context.getString(R.string.fa_category_string, categoryIndex, categoryLabel));
+    params.putString(Param.ITEM_INDEX, String.valueOf(contentIndex));
+    params.putString(Param.ITEM_NAME, context.getString(R.string.fa_contents_string, contentIndex, contentLabel));
     log(Event.SELECT_MENU, params);
   }
 
@@ -237,8 +236,8 @@ public class FirebaseAnalyticsHelper extends Helper {
     Bundle params = new Bundle();
     params.putString(Param.SCREEN, screen);
     params.putString(Param.CATEGORY_INDEX, String.valueOf(categoryIndex));
-    params.putString(Param.CATEGORY_NAME, context.getString(R.string.fa_main_category_string, categoryIndex, categoryLabel));
-    params.putString(Param.CONTENTS_NAME, contentLabel);
+    params.putString(Param.CATEGORY_NAME, context.getString(R.string.fa_category_string, categoryIndex, categoryLabel));
+    params.putString(Param.ITEM_NAME, context.getString(R.string.fa_item_string, contentLabel));
     log(Event.SELECT_SORT, params);
   }
 

+ 1 - 1
app/src/main/java/kr/co/zumo/app/lifeplus/view/screen/category/CategoryMainPresenter.java

@@ -114,7 +114,7 @@ public abstract class CategoryMainPresenter<M extends CategoryMainModel, V exten
   protected final void startInternalOnce() {
     firebaseAnalyticsHelper.logScreen(
       R.string.fa_screen_category,
-      ResourceUtil.getString(R.string.fa_main_category_string, model.getCategoryIndex() + 1, getAnalyticsScreenName())
+      ResourceUtil.getString(R.string.fa_category_string, model.getCategoryIndex() + 1, getAnalyticsScreenName())
     );
 
     init();

+ 3 - 2
app/src/main/res/values/strings.xml

@@ -939,8 +939,9 @@
   <string name="fa_screen_main">메인</string>
   <string name="fa_screen_category">카테고리</string>
 
-  <string name="fa_main_category_string">Category [%d] %s</string>
-  <string name="fa_main_contents_string">Item [%d] %s</string>
+  <string name="fa_category_string">Category [%d] %s</string>
+  <string name="fa_contents_string">Item [%d] %s</string>
+  <string name="fa_item_string">Item %s</string>
 
   <string name="fa_bi">BI</string>
   <string name="fa_search">검색</string>